Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add case for mem balloon autodeflate #5196

Merged
merged 1 commit into from
Oct 25, 2023
Merged

add case for mem balloon autodeflate #5196

merged 1 commit into from
Oct 25, 2023

Conversation

nanli1
Copy link
Contributor

@nanli1 nanli1 commented Sep 20, 2023 •
edited
Loading

VIRT-299026: Memory balloon autodeflate config
Signed-off-by: nanli [email protected]


avocado run --vt-type libvirt --test-runner=runner --vt-machine-type q35 memory.balloon

 (1/9) type_specific.io-github-autotest-libvirt.memory.balloon.memory_allocation.autodeflate_undefined.virtio_model: PASS (24.65 s)
 (2/9) type_specific.io-github-autotest-libvirt.memory.balloon.memory_allocation.autodeflate_undefined.virtio_trans_model: PASS (28.22 s)
 (3/9) type_specific.io-github-autotest-libvirt.memory.balloon.memory_allocation.autodeflate_undefined.virtio_non_trans_model: PASS (28.28 s)
 (4/9) type_specific.io-github-autotest-libvirt.memory.balloon.memory_allocation.autodeflate_off.virtio_model: PASS (28.13 s)
 (5/9) type_specific.io-github-autotest-libvirt.memory.balloon.memory_allocation.autodeflate_off.virtio_trans_model: PASS (28.21 s)
 (6/9) type_specific.io-github-autotest-libvirt.memory.balloon.memory_allocation.autodeflate_off.virtio_non_trans_model: PASS (30.18 s)
 (7/9) type_specific.io-github-autotest-libvirt.memory.balloon.memory_allocation.autodeflate_on.virtio_model: PASS (28.10 s)
 (8/9) type_specific.io-github-autotest-libvirt.memory.balloon.memory_allocation.autodeflate_on.virtio_trans_model: PASS (28.17 s)
 (9/9) type_specific.io-github-autotest-libvirt.memory.balloon.memory_allocation.autodeflate_on.virtio_non_trans_model: PASS (28.13 s)

Depend on avocado-framework/avocado-vt#3768

@nanli1 nanli1 force-pushed the add_case_for_mem_balloon_autodeflate branch from 22e7613 to 9db4938 Compare September 20, 2023 08:37
@nanli1 nanli1 mentioned this pull request Sep 20, 2023
Merged
@nanli1
Copy link
Contributor Author

nanli1 commented Sep 20, 2023

modular_redesign

chunfuwen
chunfuwen reviewed Sep 25, 2023
View reviewed changes
libvirt/tests/src/memory/memory_balloon/mem_balloon_autodeflate.py Outdated
2.autodeflate: on, off, default.
3.mem config: mem, current mem.
"""
def get_memtotal():
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

get_memtotal() --> get_memtotal_vm_internal() to avoid confused with host memory

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks chunfu,Done

chunfuwen
chunfuwen reviewed Sep 25, 2023
View reviewed changes
libvirt/tests/src/memory/memory_balloon/mem_balloon_autodeflate.py
def teardown_test():
"""
Clean data.
"""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you miss destroy VM in teardown part?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, chunfu, We will get inactive guest after sync()

@nanli1 nanli1 force-pushed the add_case_for_mem_balloon_autodeflate branch from 9db4938 to d6409f5 Compare September 26, 2023 06:31
@nanli1
add case for mem balloon autodeflate
8d70873 
   VIRT-299026: Memory balloon autodeflate config
Signed-off-by: nanli <[email protected]>
@nanli1 nanli1 force-pushed the add_case_for_mem_balloon_autodeflate branch from d6409f5 to 8d70873 Compare October 8, 2023 08:28
@nanli1 nanli1 requested a review from chunfuwen October 8, 2023 08:30
cliping
cliping approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@cliping cliping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

chunfuwen
chunfuwen approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@chunfuwen chunfuwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chunfuwen chunfuwen merged commit b8f26ce into autotest:master Oct 25, 2023
5 checks passed
@chunfuwen chunfuwen added the depend on The PR has dependency on other PRs label Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chunfuwen chunfuwen chunfuwen approved these changes

@cliping cliping cliping approved these changes

Assignees
No one assigned
Labels
depend on The PR has dependency on other PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nanli1 @cliping @chunfuwen